Separate to multiple packages wokwi-client-js and wokwi-cli
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new package, wokwi-client-js, to encapsulate API client functionality and transport mechanisms. - Updated wokwi-cli to utilize the new wokwi-client-js for API interactions, improving modularity and maintainability. - Refactored various components in wokwi-cli to support the new client structure, including changes to file uploads and command handling. - Enhanced error handling and connection management in the WebSocket transport layer. - Added new bundling script for the CLI and improved project structure for better organization. - Updated package.json and lock files to reflect new dependencies and scripts.
- Introduced Playwright for end-to-end testing, including new test scripts and configurations. - Updated .gitignore to exclude Playwright reports and test results. - Enhanced ESLint configuration to ignore Playwright-related files. - Added new scripts in package.json for running Playwright tests. - Created a new Playwright configuration file and integrated it into the TypeScript setup. - Updated GitHub workflows to include Playwright browser installation and testing steps. - Refactored wokwi-cli to improve modularity and maintainability with new transport mechanisms.
- Updated the test command in package.json to include separate scripts for vitest and CLI integration tests. - Added a new script for running CLI integration tests. - Modified GitHub workflows to run tests in a more structured manner. - Removed the obsolete CLI integration test workflow file. - Updated .gitignore to exclude the new test project directory.
Contributor
|
Thanks! I started reviewing the PR. In the meanwhile, can you please update the "Development" section in the README to use |
Contributor
|
Also, I see we now need to run |
Contributor
|
The playwright tests are really nice, thanks for adding them! |
urish
reviewed
Nov 18, 2025
Contributor
|
Looks like the release.yml workflow is also broken:
Can you please look into this as well? |
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
urish
reviewed
Nov 18, 2025
…ration test script with TypeScript version
JakubAndrysek
force-pushed
the
monorepo-separation
branch
from
cc432be to
ef83c78
Compare
…rignore, and improve code formatting across multiple files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the Wokwi CLI package by refactoring its internal API client usage, introducing a new WebSocket transport layer, and enhancing the test and build infrastructure. The main themes are: decoupling from internal API client code in favor of the shared
wokwi-client-jspackage, adding robust WebSocket connection management, and improving CI workflows and test coverage.